Gina, I am not sure if this is a Octoprint issue or File manager plugin issue but it would be real nice if there was the ability to edit folder names!
OctoPrint doesn't seem to have any native support for renaming (even files), so if you are seeing that anywhere, it's probably in the File Manager plugin.
As of this PR, this is implemented! Ready for 1.7.0.
OctoPrint:maintenance ← sparxooo:filefolder-rename
opened 01:55AM - 27 Apr 21 UTC
<!--
Thank you for your interest into contributing to OctoPrint, it's
highly a… ppreciated!
Please make sure you have read the "guidelines for contributing" as
linked just above this form, there's a section on Pull Requests in there
as well that contains important information.
As a summary, please make sure you have ticked all points on this
checklist:
-->
* [**X**] Your changes are not possible to do through a plugin and relevant
to a large audience (ideally all users of OctoPrint)
* [N/A] If your changes are large or otherwise disruptive: You have
made sure your changes don't interfere with current development by
talking it through with the maintainers, e.g. through a
Brainstorming ticket
* [**X**] Your PR targets OctoPrint's devel branch if it's a completely
new feature, or maintenance if it's a bug fix or improvement of
existing functionality for the current stable version (no PRs
against master or anything else please)
* [**X**] Your PR was opened from a custom branch on your repository
(no PRs from your version of master, maintenance or devel please),
e.g. dev/my_new_feature or fix/my_bugfix
* [**X**] Your PR only contains relevant changes: no unrelated files,
no dead code, ideally only one commit - rebase and squash your PR
if necessary!
* [**X**] Your changes follow the existing coding style
* [N/A] If your changes include style sheets: You have modified the
.less source files, not the .css files (those are generated with
lessc)
* [**X**] You have tested your changes (please state how!) - ideally you
have added unit tests
* [**X**] You have run the existing unit tests against your changes and
nothing broke
* [**X**] You have added yourself to the AUTHORS.md file :)
<!--
Describe your PR further using the template provided below. The more
details the better!
-->
#### What does this PR do and why is it necessary?
I've added the ability to rename files (accessed by the move dialog). You can move and rename in one operation, just move, or just rename. This code is an updated version of the previous PR (but i'm so new to git, I got lost...) so let's try again!
#### How was it tested? How can it be tested by the reviewer?
Upload some files and move them around!
I've tested as far as I can with special characters (including where OctoPrint uses a different name internally), and it seems to work (except in the case of renaming again, whereby it uses the "safe" internal name).
PyTest passes with 6 warnings (not in my touched files)
pre-commit touched some files but since passed.
#### Any background context you want to provide?
I have a Cura OctoPrint plugin which unfortunately uploads with a very generic name. I wanted to rename and move those files, and realised I couldn't.
#### What are the relevant tickets if any?
#2694
#### Screenshots (if appropriate)
#### Further notes
1 Like
Wasn't seeing that ability, I was saying that it was something that ought to be made possible in future releases. It seems that is coming in the next release
Thank you, that is great!