Action Command Notification Support -plugin flood whole webUI

kermus · December 4, 2020, 6:55pm

What is the problem?

Action Command Notification Support -plugin "printer notification" labels flood the entire webUI when the printer runs, for example, G29 w / bedheat

could these “stickers” be stackable or disappear after xx time

the hotfix is to reload the page and the "stickers" will disappear for a while and you will have to start all over again

Complete Logs

octoprint(2).log (152.4 KB)

Additional information about your setup

browser.user_agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:83.0) Gecko/20100101 Firefox/83.0
connectivity.connection_check: 9.9.9.9:53
connectivity.connection_ok: true
connectivity.enabled: true
connectivity.online: true
connectivity.resolution_check: octoprint.org
connectivity.resolution_ok: true
env.hardware.cores: 4
env.hardware.freq: 1200
env.hardware.ram: 917016576
env.os.bits: 32
env.os.id: linux
env.os.platform: linux2
env.plugins.pi_support.model: Raspberry Pi 3 Model B Rev 1.2
env.plugins.pi_support.octopi_version: 0.17.0
env.plugins.pi_support.throttle_state: 0x0
env.python.pip: 19.3.1
env.python.version: 2.7.16
env.python.virtualenv: true
octoprint.safe_mode: false
octoprint.version: 1.5.1
printer.firmware: Marlin bugfix-2.0.x (Dec 4 2020

Charlie_Powell · December 4, 2020, 7:06pm

You can turn off popups, in the 'Printer Notifications'/'Action Command Notification' plugin settings:

It is currently not possible to change settings to make them dismiss, but we might be able to look at that in the future.

foosel · December 4, 2020, 8:17pm

Also you should look into your firmware, your printer should not generate these many notifications in the first place, and the fact that it does indicates a firmware bug or misconfiguration.

kermus · December 5, 2020, 2:36pm

now you missed the point of this problem.
yes i can turn notifications off, yes i can edit firmware and remove Action Command from it.

but why couldn't the plugin stack "stickers" or destroy them according to time or amount e.g. last xx sticker is displayed

Charlie_Powell · December 5, 2020, 6:15pm

Well, they could, but they aren't. So we are providing temporary fixes, until a solution in the code can be found to stack/make them disappear. No guarantees, but also it is not usually an issue (my printer only sends one of these notifications, so this problem is not widespread.)

foosel · December 7, 2020, 10:09am

You missed the point It would never need to do that and actually should never do that if the action notification support wasn't being abused by the firmware here to spam the host with notifications that add absolutely no value for the user. The whole idea behind this feature was to alert the user to rare situations that require their attention. Yet for some reason now there is apparently firmware out there that instead almost uses this as a debugging interface. That's not what the plugin was meant to support. The notifications don't vanish because they are meant to be seen, they might contain important information, if they just aged out or went into overflow or something, important notifications would no longer be seen on machines where the firmware doesn't abuse this mechanism to spam people.

I'm telling you that the problem here is with how the feature is being used, or rather abused, by the firmware. And since I can't prevent this from happening, now I once again will get to spend time and energy on implementing a workaround to keep this from causing problems for the users, but for now I suggest you disable popups and investigate why the heck your firmware is so overlay communicative in the first place (it also unnecessarily hogs bandwidth on the serial interface and causes parsing overhead in OctoPrint).